feat: improve LNURL ux #2152
feat: improve LNURL ux #2152
Conversation
|
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. This build is brought to you by: Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name) Don't forget: keep earning sats! |
| @@ -420,6 +420,8 @@ function LNURLPay() { | |||
| fiatValue={fiatValue} | |||
| /> | |||
| <SatButtons | |||
| min={Math.floor(+details.minSendable / 1000)} | |||
There was a problem hiding this comment.
is minSendable always available? undefined / 1000 = NaN
There was a problem hiding this comment.
I think min / max are required fields for LNURL responses. Other components on this form use those value the same way:
|
Does this make #1697 obsolete? |
I think so, yes. It just makes more sense to me (and is a lot less complicated I guess). |
| <Button | ||
| key={size} | ||
| icon={<SatoshiV2Icon className="w-4 h-4" />} | ||
| label={size / 1000 + "k"} |
There was a problem hiding this comment.
so the head of Emoji is removing the ⚡️ emojis here?
Describe the changes you have made in this PR
Have the LNURL payment form respect the provided
minandmaxvalues.Link this PR to an issue [optional]
Fixes #1569
Type of change
feat: New feature (non-breaking change which adds functionality)Screenshots of the changes [optional]
How has this been tested?
LNURLs used for testing
Checklist